From ab81cf7eac462a00aabbdaf2e78857d04f5d1eb1 Mon Sep 17 00:00:00 2001 From: j0n3lson <620536+j0n3lson@users.noreply.github.com> Date: Thu, 9 Jan 2020 17:11:23 -0800 Subject: [PATCH 1/2] Use a more k8s/release friendly PR template. --- .github/pull_request_template.md | 56 +++++++++++++++++++------------- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8e80f9c..ef36d27 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,38 +4,57 @@ If a section of the PR template does not apply to this PR, then delete that section. --> -## Motivation +## What type of PR is this? -_(fill-in or delete this section)_ +_(REQUIRED)_ + + + +## What this PR does / why we need it: + +_(REQUIRED)_ + +## Which issue(s) this PR fixes: + +_(REQUIRED)_ + -## Release Notes +## Special notes for your reviewer: _(fill-in or delete this section)_ -## Changes +## Release Notes -_(fill-in or delete this section)_ +_(REQUIRED)_ ## Testing @@ -44,13 +63,4 @@ _(fill-in or delete this section)_ - -## Reviewer Guidelines - -_(fill-in or delete this section)_ - - +--> \ No newline at end of file From 78ba678e4e37ea87e7f8dd8823b8a202a0522041 Mon Sep 17 00:00:00 2001 From: j0n3lson <620536+j0n3lson@users.noreply.github.com> Date: Fri, 10 Jan 2020 01:04:12 -0800 Subject: [PATCH 2/2] Modifications per review --- .github/pull_request_template.md | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ef36d27..4a30f8f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,12 +8,10 @@ _(REQUIRED)_ - +- [ ] bug +- [ ] cleanup +- [ ] documentation +- [ ] feature ## What this PR does / why we need it: @@ -46,21 +44,26 @@ _(fill-in or delete this section)_ Which parts of the code should reviewers focus on? --> +## Testing + +_(fill-in or delete this section)_ + + + ## Release Notes _(REQUIRED)_ - -## Testing + Put your text between the block. To omit notes, use NONE within the block. +--> -_(fill-in or delete this section)_ +```release-note - \ No newline at end of file +``` \ No newline at end of file