From 80fdcd65de500083e0164114b1da8f4b4d0ef7aa Mon Sep 17 00:00:00 2001 From: Daanikus Date: Thu, 31 Oct 2019 15:25:15 +1300 Subject: [PATCH 1/2] add missing call to file.Close() --- build.go | 1 + 1 file changed, 1 insertion(+) diff --git a/build.go b/build.go index a78ded3..f43a818 100644 --- a/build.go +++ b/build.go @@ -137,6 +137,7 @@ func GfmrunActionFunc(c *cli.Context) error { if err != nil { return err } + defer file.Close() var counter int scanner := bufio.NewScanner(file) From 310284f8d7b5104ea081463221cfbd4b37c30dae Mon Sep 17 00:00:00 2001 From: Dan Bent Date: Fri, 8 Nov 2019 13:56:05 +1300 Subject: [PATCH 2/2] close file using existing style --- build.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/build.go b/build.go index f43a818..579a827 100644 --- a/build.go +++ b/build.go @@ -137,7 +137,6 @@ func GfmrunActionFunc(c *cli.Context) error { if err != nil { return err } - defer file.Close() var counter int scanner := bufio.NewScanner(file) @@ -147,6 +146,11 @@ func GfmrunActionFunc(c *cli.Context) error { } } + err = file.Close() + if err != nil { + return err + } + err = scanner.Err() if err != nil { return err