x/urfave-cli
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

big guidance

Browse Source
This commit is contained in:
Lynn 2020-02-29 00:33:51 -08:00
parent 365dd2b4cb
commit 055c9c076d
No known key found for this signature in database
GPG Key ID: 9E60BEE0555C367B
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
internal/build/build.go
View File

@ -227,17 +227,28 @@ func checkBinarySizeActionFunc(c *cli.Context) (err error) {
// show guidance // show guidance
fmt.Println(fmt.Sprintf("\n%s is the current binary size", roundedFileSizeString)) fmt.Println(fmt.Sprintf("\n%s is the current binary size", roundedFileSizeString))
// show guidance for min size
if isLessThanDesiredMin { if isLessThanDesiredMin {
fmt.Println(fmt.Sprintf(" %s current binary size is %s", goodNewsEmoji, desiredMinSizeString)) fmt.Println(fmt.Sprintf(" %s %s is the target min size", goodNewsEmoji, desiredMinSizeString))
fmt.Println("") // visual spacing
fmt.Println(" The binary is smaller than the target min size, which is great news!")
fmt.Println(" That means that whatever you've done is shrinking the binary size.")
fmt.Println(" You'll want to go into ./internal/build/build.go and decrease")
fmt.Println(" the desiredMinBinarySize, and also probably decrease the ")
fmt.Println(" desiredMaxBinarySize by the same amount. That will ensure that")
fmt.Println(" future PRs will enforce the newly shrunk binary sizes.")
fmt.Println("") // visual spacing
os.Exit(1) os.Exit(1)
} else { } else {
fmt.Println(fmt.Sprintf(" %s %s is the target minium size", checksPassedEmoji, desiredMinSizeString)) fmt.Println(fmt.Sprintf(" %s %s is the target min size", checksPassedEmoji, desiredMinSizeString))
} }
// show guidance for max size
if isMoreThanDesiredMax { if isMoreThanDesiredMax {
fmt.Println(fmt.Sprintf(" %s current binary size is %s", badNewsEmoji, desiredMaxSizeString)) fmt.Println(fmt.Sprintf(" %s %s is the target max size", badNewsEmoji, desiredMaxSizeString))
fmt.Println("") // visual spacing
os.Exit(1) os.Exit(1)
} else { } else {
fmt.Println(fmt.Sprintf(" %s %s is the target maximum size", checksPassedEmoji, desiredMaxSizeString)) fmt.Println(fmt.Sprintf(" %s %s is the target max size", checksPassedEmoji, desiredMaxSizeString))
} }
return nil return nil