From 40d222c164cff13091a91098ad34c349f310cc6f Mon Sep 17 00:00:00 2001 From: Dan Buch Date: Thu, 26 Nov 2009 08:30:33 -0500 Subject: [PATCH] returning a list from padfill to cut down on all the str.join ops --- onetimepad.py | 2 +- test_onetimepad.py | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/onetimepad.py b/onetimepad.py index a535d41..00e96ea 100644 --- a/onetimepad.py +++ b/onetimepad.py @@ -49,7 +49,7 @@ def _padfill(text, pad): continue else: padlines[lineno] = textlines.pop(0) if textlines[1:] else '' - return '\n'.join(padlines) + return padlines def _get_textwidth(text): diff --git a/test_onetimepad.py b/test_onetimepad.py index 680b83a..55eb536 100644 --- a/test_onetimepad.py +++ b/test_onetimepad.py @@ -38,10 +38,8 @@ class TestOneTimePad(unittest.TestCase): msg = self.msg[:] pad = OT.create_pad(len(msg)) filled = OT._padfill(msg, pad) - # print filled - # raise Exception self.assertTrue(bool(filled)) - for lineno, line in enumerate(filled.splitlines()): + for lineno, line in enumerate(filled): line = line.strip() if OT._is_cypherline(lineno): self.assertFalse(bool(len(line)),