x/box-o-sand
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fixing (?) the strncpy bug

Browse Source
This commit is contained in:
Dan Buch 2011-09-21 22:23:37 -04:00
parent 791f3b1327
commit 198b54d316
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ex17.c
View File

@ -107,13 +107,13 @@ void Database_set(struct Connection *conn, int id, const char *name, const char
if(addr->set) die("Already set, delete it first"); if(addr->set) die("Already set, delete it first");
addr->set = 1; addr->set = 1;
// WARNING: bug, read the "How To Break It" and fix this
char *res = strncpy(addr->name, name, MAX_DATA); char *res = strncpy(addr->name, name, MAX_DATA);
// demonstrate the strncpy bug
if(!res) die("Name copy failed"); if(!res) die("Name copy failed");
addr->name[MAX_DATA - 1] = '\0';
res = strncpy(addr->email, email, MAX_DATA); res = strncpy(addr->email, email, MAX_DATA);
if(!res) die("Email copy failed"); if(!res) die("Email copy failed");
addr->email[MAX_DATA - 1] = '\0';
} }
void Database_get(struct Connection *conn, int id) void Database_get(struct Connection *conn, int id)